Skip to content

Comments

[py] Fix test for w3c touch pointer properties#15580

Merged
cgoldberg merged 2 commits intoSeleniumHQ:trunkfrom
cgoldberg:py-fix-w3c-interactions-test
Apr 6, 2025
Merged

[py] Fix test for w3c touch pointer properties#15580
cgoldberg merged 2 commits intoSeleniumHQ:trunkfrom
cgoldberg:py-fix-w3c-interactions-test

Conversation

@cgoldberg
Copy link
Member

@cgoldberg cgoldberg commented Apr 6, 2025 •
edited by qodo-code-review bot
Loading

User description

💥 What does this PR do?

This PR fixes the test_touch_pointer_properties test in the internal Python test suite. It was failing in CI runs.

This test would run fine in isolation, but fail when the entire test file was run because the pointer state was leaked from a previous test.

This change resets the pointer to position 0, 0 at the beginning of the test so it is always in a known state when running.

🔄 Types of changes

  • Bug fix (backwards compatible)

PR Type

Bug fix

Description

  • Fixes test_touch_pointer_properties to reset pointer state.

  • Adds pointer reset action to ensure test isolation.

  • Clears event state before running the test.

Changes walkthrough 📝

Relevant files
Tests
w3c_interaction_tests.py
Fix and enhance `test_touch_pointer_properties` setup       

py/test/selenium/webdriver/common/w3c_interaction_tests.py

  • Added pointer reset action to ensure known starting state.
  • Cleared event state before running the test.
  • Adjusted test setup for better isolation and reliability.
    		• +11/-1   
    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
    •

    @selenium-ci selenium-ci added the C-py Python Bindings label Apr 6, 2025
    @qodo-code-review
    Copy link
    Contributor

    qodo-code-review bot commented Apr 6, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 PR contains tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Variable Scope

    The touch_input variable was moved outside the ActionBuilder call, but it's now used before it's defined in the reset_actions. Verify this doesn't cause issues in other test execution contexts.

     
    touch_input = PointerInput(interaction.POINTER_TOUCH, "touch")

    @qodo-code-review
    Copy link
    Contributor

    qodo-code-review bot commented Apr 6, 2025 •
    edited
    Loading

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @cgoldberg
    Copy link
    Member Author

    cgoldberg commented Apr 6, 2025

    The touch_input variable was moved outside the ActionBuilder call, but it's now used before it's defined in the reset_actions.

    It was not moved outside the ActionBuilder call and is not defined in reset_actions (although it's used there).

    I love arguing with this AI PR reviewer :)

    @cgoldberg cgoldberg mentioned this pull request Apr 6, 2025
    Merged
    @cgoldberg
    Copy link
    Member Author

    cgoldberg commented Apr 6, 2025

    All tests pass in CI except the 1 failure caused by #15581 (unrelated to this PR)

    @cgoldberg cgoldberg merged commit c551357 into SeleniumHQ:trunk Apr 6, 2025
    16 of 17 checks passed
    @cgoldberg cgoldberg deleted the py-fix-w3c-interactions-test branch April 6, 2025 05:58
    @garrettgregor garrettgregor mentioned this pull request May 3, 2025
    Merged
    This was referenced Sep 12, 2025
    Closed
    Closed
    Merged
    This was referenced Sep 19, 2025
    Closed
    Closed
    Closed
    This was referenced Oct 1, 2025
    Closed
    Closed
    Closed
    @dependabot dependabot bot mentioned this pull request Oct 24, 2025
    Closed
    This was referenced Dec 21, 2025
    Open
    Closed
    Closed
    Closed
    This was referenced Jan 19, 2026
    Open
    Open
    Open
    Merged
    This was referenced Feb 16, 2026
    Closed
    Open
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    No reviews

    Assignees

    No one assigned

    Labels

    C-py Python Bindings Review effort 2/5

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    2 participants

    @cgoldberg @selenium-ci